Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename libraries to match repo names #425

Closed
elbrujohalcon opened this issue Feb 8, 2017 · 1 comment
Closed

Rename libraries to match repo names #425

elbrujohalcon opened this issue Feb 8, 2017 · 1 comment
Assignees
@igaray
Milestone
0.5.0

Comments

@elbrujohalcon
Copy link
Member

  • elvis' app is now called elvis_shell
  • elvis_core's app is called elvis

That's a mess. This is how they should be called:

  • elvis app: elvis
  • elvis_core: elvis_core
@elbrujohalcon
Copy link
Member Author

This will be a backwards-incompatible change (users of elvis_core that call it elvis will break) but I think it's needed and easily solvable from the user's perspective.

@igaray igaray self-assigned this Jan 2, 2019
@igaray igaray added this to the 0.4.0 milestone Jan 2, 2019
@jfacorro jfacorro mentioned this issue Dec 18, 2019
Merged
elbrujohalcon added a commit to inaka/elvis_core that referenced this issue Dec 18, 2019
@elbrujohalcon
Merge pull request #116 from inaka/425-rename-application
59043b5 
[inaka/elvis#425] Rename application to elvis_core
@jfacorro jfacorro mentioned this issue Dec 18, 2019
Merged
elbrujohalcon added a commit to inaka/elvis_core that referenced this issue Dec 18, 2019
@elbrujohalcon
Merge pull request #117 from inaka/425-rename-application-update-readme
5fd30f5 
[inaka/elvis#425] Update README after renaming the application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igaray igaray

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@elbrujohalcon @igaray @jfacorro