Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new PR review feature #449

Closed
harenson opened this issue Jun 12, 2017 · 0 comments
Closed

Use the new PR review feature #449

harenson opened this issue Jun 12, 2017 · 0 comments
Assignees
@harenson
Labels
enhancement

Comments

@harenson
Copy link
Member

harenson commented Jun 12, 2017 •
edited
Loading

So far, for every "issue" elvis finds in code it creates a comment within the PR. The idea is to send just one POST to github with all the found issues, something like this https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review
@harenson harenson self-assigned this Jun 12, 2017
@harenson harenson changed the title Perform required changes for using the new PR review Perform required changes for using the new PR review feature Jun 12, 2017
@harenson harenson changed the title Perform required changes for using the new PR review feature Use the new PR review feature Jul 5, 2017
elbrujohalcon pushed a commit that referenced this issue Jul 6, 2017
Merge pull request #457 from inaka/harenson.449.use-the-new-pr-review…
25d1703 
…-feature

[Fix #449] Use the new GitHub's PR review feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harenson harenson

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harenson