-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elvis_core violates OTP naming conventions #491
Comments
That's because the application in that repository (http://github.com/inaka/elvis_core), despite the repo's name, is actually |
This is partial/temporary fix for inaka/elvis#491
I adjusted the README.md in inaka/elvis_core#105 but I'll leave this ticket open since we do have the desire to fix it properly. |
Ok, so the application in the |
[#491] Update elvis_core with correct OTP naming
Milestone removed, since 0.5.0 is in the past. |
This was fixed in |
According to OTP naming conventions (see http://erlang.org/doc/design_principles/applications.html#directory-structure), the application resource file is supposed to be
src/${application}.app.src
, but forelvis_core
this file is calledsrc/elvis.app.src
. Also, the file contents specifies the application name to be "elvis" instead of "elvis_core".This means that we cannot start the
elvis_core
application as documented by doingapplication:start(elvis_core).
:The text was updated successfully, but these errors were encountered: