Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master doesn't build #503

Closed
lpgauth opened this issue Jun 19, 2019 · 6 comments
Closed

Master doesn't build #503

lpgauth opened this issue Jun 19, 2019 · 6 comments
Assignees
Labels

Comments

@lpgauth
Copy link

lpgauth commented Jun 19, 2019

~/Git/elvis [master|…1]
12:57 $ ./rebar3 compile
===> Verifying dependencies...
===> Fetching egithub v0.5.5
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/egithub-0.5.5.tar is up to date, reusing it
===> Fetching elvis v0.4.2
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/elvis_core-0.4.2.tar is up to date, reusing it
===> Fetching getopt v1.0.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/getopt-1.0.1.tar is up to date, reusing it
===> Fetching katana_code v0.1.2
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/katana_code-0.1.2.tar is up to date, reusing it
===> Fetching aleppo v1.1.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/inaka_aleppo-1.1.1.tar is up to date, reusing it
===> Fetching goldrush v0.1.9
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/goldrush-0.1.9.tar is up to date, reusing it
===> Fetching hackney v1.13.0
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/hackney-1.13.0.tar is up to date, reusing it
===> Fetching jiffy v0.15.2
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/jiffy-0.15.2.tar is up to date, reusing it
===> Fetching lager v3.6.3
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/lager-3.6.3.tar is up to date, reusing it
===> Fetching zipper v1.0.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/zipper-1.0.1.tar is up to date, reusing it
===> Fetching certifi v2.3.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/certifi-2.3.1.tar is up to date, reusing it
===> Fetching idna v5.1.2
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/idna-5.1.2.tar is up to date, reusing it
===> Fetching metrics v1.0.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/metrics-1.0.1.tar is up to date, reusing it
===> Fetching mimerl v1.0.2
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/mimerl-1.0.2.tar is up to date, reusing it
===> Fetching ssl_verify_fun v1.1.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/ssl_verify_fun-1.1.1.tar is up to date, reusing it
===> Fetching parse_trans v3.2.0
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/parse_trans-3.2.0.tar is up to date, reusing it
===> Fetching unicode_util_compat v0.3.1
===> Version cached at /Users/lp.gauthier/.cache/rebar3/hex/hexpm/packages/unicode_util_compat-0.3.1.tar is up to date, reusing it
===> Compiling mimerl
===> Compiling aleppo
===> Compiling getopt
===> Compiling unicode_util_compat
===> Compiling goldrush
===> Compiling lager
/Users/lp.gauthier/Git/elvis/_build/default/lib/lager/src/lager_util.erl: redefining predefined macro 'FUNCTION_NAME'
===> Compiling _build/default/lib/lager/src/lager_util.erl failed
_build/default/lib/lager/src/lager_util.erl:none: redefining predefined macro 'FUNCTION_NAME'
@elbrujohalcon
Copy link
Member

Hi @lpgauth 👋
Is that OTP22?

@elbrujohalcon
Copy link
Member

I tested it with OTP21 and indeed I get the same error. I'll keep digging.

@elbrujohalcon
Copy link
Member

Yeah… we need a new version of egithub which, in turn, should use a newer version of lager…

@elbrujohalcon
Copy link
Member

Thanks for the report, @lpgauth … we'll fix this soon :)

@jfacorro jfacorro self-assigned this Jun 19, 2019
jfacorro added a commit that referenced this issue Jun 24, 2019
jfacorro added a commit that referenced this issue Jun 24, 2019
jfacorro added a commit that referenced this issue Jun 24, 2019
jfacorro added a commit that referenced this issue Jun 24, 2019
@jfacorro
Copy link
Contributor

Current master should build now. But we will create a new release soon. Thank you for reporting this!

@lpgauth
Copy link
Author

lpgauth commented Jun 26, 2019

Thanks, I just tried and built master successfully. 👍

@lpgauth lpgauth closed this as completed Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants