Stricter match for macros as module/function names #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids matching expressions that have colons but are not function calls, for example when matching or building binaries. The main change is that the regular expression only matches if there is a left parenthesis following the function name, with zero or more whitespace characters in between. The '[A-z0-9_]' pattern has been replaced by '\\w' only because the expression became a bit long otherwise.
|
@dvaergiller Would it be possible to add some expression(s) that shouldn't fail in |
|
I double-checked that the additions to the test causes master branch to fail (which it should not). |
jfacorro
added a commit
that referenced
this pull request
Nov 21, 2014
Stricter match for macros as module/function names
|
@dvaergiller Merged! Thanks! |
|
Should we close #172 ? |
|
@elbrujohalcon I agree, I just closed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids matching expressions that have colons but are not function
calls, for example when matching or building binaries. The main change
is that the regular expression only matches if there is a left
parenthesis following the function name, with zero or more whitespace
characters in between. The '[A-z0-9_]' pattern has been replaced by
'\w' only because the expression became a bit long otherwise.