[Closes #236] Operator space false positive #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {string, _} -> []; | ||
| {char, _} -> []; | ||
| {comment, _} -> []; | ||
| {_, string} -> []; |
There was a problem hiding this comment.
Why matching all this cases? If I'm not mistaken it would either be undefined or any of your valid options. Wouldn't matching undefined and have an otherwise default behaviour save lines?
There was a problem hiding this comment.
We have to check for those types of nodes or tokens where an operator without a space is acceptable. An alternative would be to match for all that shouldn't have it, but in either case there needs to be an explicit specification of the valid (or invalid) types of nodes/tokens.
HernanRivasAcosta
added a commit
that referenced
this pull request
Aug 27, 2015
…positive [Closes #236] Operator space false positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#236