Add variable names rule #283
Conversation
| { | ||
| elvis_style, | ||
| variable_naming_convention, | ||
| #{regex => "^([A-Z][0-9a-zA-Z]*)*$", ignore => []} |
There was a problem hiding this comment.
I don't think you need the external star, i.e. you can get the same results with just [A-Z][0-9a-zA-Z]*.
I'm also pretty sure your regex will render _ThisTotallyValidVariable as invalid.
I think the proper default value should be along the lines of ^_?[A-Z][0-9a-zA-Z]*$ or maybe better we should ignore the leading _ when matching regexes in code.
There was a problem hiding this comment.
Yeah, you're right, let me change it.
|
Don't forget to add the new rule to the wiki |
| nomatch -> | ||
| Msg = ?VARIABLE_NAMING_CONVENTION_MSG, | ||
| Info = [VariableNameStr, Regex], | ||
| Result = elvis_result:new(item, Msg, Info, 1), |
There was a problem hiding this comment.
Please provide the location of the variable in the error message so that it is easier to find. You can check the following code here to know how to extract the location information from a node.
| Msg = ?VARIABLE_NAMING_CONVENTION_MSG, | ||
| {Line, _} = ktn_code:attr(location, Variable), | ||
| Info = [VariableNameStr, Line, Regex], | ||
| Result = elvis_result:new(item, Msg, Info, 1), |
There was a problem hiding this comment.
You should use Line here, instead of 1
|
@harenson Since another PR was merged before this one, it is necessary to synchronize this branch with the |
|
@jfacorro Ok, I will take care of it in a while. |
|
@jfacorro @elbrujohalcon Thanks for your reviews 👍 |
|
@harenson Merged! 🎉 |
|
🎉 |
No description provided.