Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#163] No nesting try…catch'es #284

Merged
merged 5 commits into from
Oct 14, 2015
Merged

[#163] No nesting try…catch'es #284

merged 5 commits into from
Oct 14, 2015

Conversation

ElFantasma
Copy link
Contributor

No description provided.

@elbrujohalcon
Copy link
Member

Thank you, @ElFantasma … can you please add the rule to the wiki?

Predicate = fun(Node) -> ktn_code:type(Node) == 'try' end,
FilterMapFun =
fun (Node) ->
case Node /= TryExp of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid using this case expression here by using pattern matching in the fun's clauses.

@ElFantasma
Copy link
Contributor Author

Done writing the rule on the wiki, and correcting jfacorro's comments. Should I do something else?

jfacorro added a commit that referenced this pull request Oct 14, 2015
@jfacorro jfacorro merged commit ec03cff into inaka:master Oct 14, 2015
@jfacorro
Copy link
Contributor

@ElFantasma Nope, nothing else is required. Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants