Remove Lager as a direct dependency of Elvis #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lager is a dependency of egithub so the total alcohol content by volume is not decreased. Nonetheless, we no longer perform the Lager parse transform on the Elvis source files. Fixes inaka#318
|
@Euen can you fix the issue on egithub, please so we can upgrade egithub version here and then merge this PR? |
waisbrot
added a commit
to waisbrot/elvis_core
that referenced
this pull request
Oct 25, 2016
Change the sole call to `lager:info` into `elvis_utils:print` This is the elvis_core parallel to inaka/elvis#411
waisbrot
added a commit
to waisbrot/elvis_core
that referenced
this pull request
Oct 25, 2016
Change the sole call to `lager:info` into `elvis_utils:info` This is the elvis_core parallel to inaka/elvis#411
|
Looks like the latest erlang-github already works. Let me know if you don't want that upgrade as part of this PR. |
Euen
added a commit
to inaka/elvis_core
that referenced
this pull request
Apr 25, 2017
Euen
added a commit
to inaka/elvis_core
that referenced
this pull request
Apr 25, 2017
elbrujohalcon
pushed a commit
to inaka/elvis_core
that referenced
this pull request
Apr 25, 2017
WIP: [Close inaka/elvis#411] unpdate line length to 100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lager is a dependency of egithub so the total alcohol content by volume is not
decreased. Nonetheless, we no longer perform the Lager parse transform on the
Elvis source files.
Fixes #318