Add --keep-rocking switch #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
approved these changes
Feb 23, 2017
elvisci
reviewed
Mar 1, 2017
src/elvis.erl
Outdated
| [ | ||
| {help, $h, "help", undefined, "Show this help information."}, | ||
| {config, $c, "config", string, Commands}, | ||
| {commands, undefined, "commands", undefined, "Show available commands."}, | ||
| {output_format, undefined, "output-format", string, OutputFormat}, | ||
| {version, $v, "version", undefined, "Specify the elvis current version."}, | ||
| {code_path, $p, "code-path", string, "Add the directory in the code path."} | ||
| {code_path, $p, "code-path", string, "Add the directory in the code path."}, |
There was a problem hiding this comment.
Line 67 is too long: {code_path, $p, "code-path", string, "Add the directory in the code path."},.
|
@fenek would you mind satisfying our rocking overlord by reducing the length of that line? |
|
Not my code! :D Just kidding. Sure, not a problem. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switch will force Elvis to keep rocking even when it encounters an error. It applies to a case when a list of files to rock is provided. Default behaviour causes the script to stop on first faulty module.
It's useful for rocking group of modules selected with regexp. First of all, it allows to learn an overview of errors in all modules. Secondly, now it's possible to ignore some errors that are tricky to resolve (like god modules) and continue to remaining mods.