Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#380] Add a section describing elvis.config #477

Merged
merged 1 commit into from
May 5, 2018
Merged

[#380] Add a section describing elvis.config #477

merged 1 commit into from
May 5, 2018

Conversation

JohanVikman
Copy link
Contributor

No description provided.

@JohanVikman JohanVikman mentioned this pull request Oct 26, 2017
Closed
elbrujohalcon
elbrujohalcon previously requested changes Oct 26, 2017
View reviewed changes
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good place to start, now we should add an explanation on:

  • how dirs, filter and ignore_files(If I recall correctly) interact with each other
  • how are wildcard values of filter and dirs evaluated
  • how rules affect ruleset
  • etc.

@elbrujohalcon elbrujohalcon dismissed their stale review May 5, 2018 00:31

Will merge what we have so far, but keep the issue open.

@elbrujohalcon elbrujohalcon merged commit 0898f50 into inaka:master May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohanVikman @elbrujohalcon