Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken yml for GitHub Actions #559

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Fix broken yml for GitHub Actions #559

merged 1 commit into from
Jan 12, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

No description provided.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Replace Travis CI with GitHub Actions Fix broken yml for GitHub Actions Dec 11, 2020
@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Dec 11, 2020

It seems to now be failing due to a failing rebar3 version (the one packed with the Docker container). These have since been updated.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft December 14, 2020 03:22
@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Dec 14, 2020

Converting to draft to check if Action setup-erlang would solve the (apparently caused by) rebar3 issues. This is not required.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Dec 14, 2020

I'm trying to make CI's rebar3 not change between different containers. While this isn't done, I'm going to use setup-erlang for a quick fix. It's done!

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Dec 14, 2020

List of Erlang versions (our CI) is currently: 19.2, 20.3, 21.3, 22.0.
List of setup-erlang supported version is currently: http://packages.erlang-solutions.com/erlang/debian/pool/.

I'll need to fix the mismatch. I abandoned this since it's harder to maintain.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Dec 15, 2020

Still not Okay :( it seems setup-erlang prefixes the version with https://packages.erlang-solutions.com/erlang/debian/pool/esl-erlang_erlang: and suffixes it with -1~ubuntu~bionic_amd64.deb, so I need to work with that.

Edit: actually, no, the erlang: bit is a stupid typo on my behalf.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I'll look at this later. I guess the way it's build now it's not creating a proper .git locally; some adjustments might be required.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Installing Git 2.18 takes a while (2.5 minutes) but otherwise the Git SUITE won't run properly, since I can't make the checkout action create a repo. with a previous Git version. We can, otherwise, not run certain parts of the test code for older OTP versions, but I'm thinking that's probably not a better solution.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

It seems we might be missing a configuration for CI run: "\n*** Please tell me who you are.\n\nRun\n\n git config --global user.email \"you@example.com\"\n git config --global user.name \"Your Name\"\n\nto set your account's default identity.\nOmit --global to set the identity only in this repository.\n\nfatal: unable to auto-detect email address (got 'root@4fe1699c8229.(none)')\n". Let me try to tweak something into working.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review January 11, 2021 23:26
@paulo-ferraz-oliveira
Copy link
Collaborator Author

This is now, again, ready for review.

@elbrujohalcon elbrujohalcon merged commit 84faa65 into inaka:master Jan 12, 2021
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/gha branch January 13, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants