Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approach OTP 24 #560

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Approach OTP 24 #560

merged 4 commits into from
Mar 24, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

The dep. bumps refer to stuff I've adapted to OTP 24, as much as possible.

The typespec fixes are related with the new elvis_core version.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I had to bump CI min. to OTP 21 due to hackney pulling a parse_trans version that requires it. Is this acceptable?

@elbrujohalcon
Copy link
Member

I had to bump CI min. to OTP 21 due to hackney pulling a parse_trans version that requires it. Is this acceptable?

Yes

elbrujohalcon
elbrujohalcon requested changes Mar 24, 2021
View reviewed changes
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a newer elvis_core around.

rebar.config Outdated Show resolved Hide resolved
@paulo-ferraz-oliveira
Copy link
Collaborator Author

I've pushed the updated rebar.config and rebar.lock. Let's see if CI complains, otherwise I'm good to go.

@elbrujohalcon elbrujohalcon merged commit 8408015 into inaka:master Mar 24, 2021
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/approach-otp-24 branch March 24, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulo-ferraz-oliveira @elbrujohalcon