Remove none from the update options
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
force-pushed
the
elbrujohalcon.74.remove__none__from_the_update_
branch
from
acc43bd
to
e3cdadf
Compare
elbrujohalcon
assigned elbrujohalcon and HernanRivasAcosta and unassigned HernanRivasAcosta and elbrujohalcon
HernanRivasAcosta
added a commit
that referenced
this pull request
Sep 7, 2015
…_the_update_ Remove `none` from the update options
elbrujohalcon
deleted the
elbrujohalcon.74.remove__none__from_the_update_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since, after #73, we're going to ignore out-of-order client updates and
noneassumes knowledge of previous updates, we should remove it and force the client to send that piece of information all the time.