Create separate starters for embedded and client/server mode #31 #34
Conversation
| <dependency> | ||
| <groupId>org.infinispan</groupId> | ||
| <artifactId>infinispan-spring4-remote</artifactId> | ||
| <optional>true</optional> |
There was a problem hiding this comment.
Could you please include this one as well? The goal of this split is to get users who use the starters going with minimum manual stuff.
There was a problem hiding this comment.
do you mean remove optional ?
pom.xml
Outdated
| @@ -78,9 +78,11 @@ | |||
| </build> | |||
|
|
|||
| <modules> | |||
| <module>infinispan-spring-boot-starter-autoconfigure</module> | |||
| <module>infinispan-spring-boot-starter-embedded</module> | |||
| <module>infinispan-spring-boot-starter-remote</module> | |||
| <module>infinispan-spring-boot-starter</module> | |||
| <module>infinispan-spring-boot-starter-test-remote</module> | |||
There was a problem hiding this comment.
Since we've done the split, we can squash some impl and test modules like infinispan-spring-boot-starter-remote and infinispan-spring-boot-starter-test-remote.
|
Thanks a lot for the PR @lburgazzoli! There are only some small things to fix and we are good to go. |
|
Yes, exactly.
--
SEBASTIAN ŁASKAWIEC
INFINISPAN DEVELOPER
Red Hat EMEA <https://www.redhat.com/>
<https://red.ht/sig>
|
|
done:
|
| <artifactId>spring-boot-configuration-processor</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
Sorry I missed this before, this (core) needs to be removed from the remote starter.
|
Thanks @lburgazzoli ! |
|
I'll test it out with some demos and I think we can release |
No description provided.