Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove services and running containers when removing an app #80

Closed
michiels opened this issue Jan 25, 2016 · 3 comments
Closed

Remove services and running containers when removing an app #80

michiels opened this issue Jan 25, 2016 · 3 comments
Labels

Comments

@michiels
Copy link
Member

I just removed an app, but I still see a Postgres service running for it. I suggest we remove corresponding services when removing an app.

@jvanbaarsen
Copy link
Contributor

@michiels I assumed it did remove those links as well. But probably it does not actually kill the container, which might be a bug in Dokku. Will look further into this.

@michiels
Copy link
Member Author

Agreed. I also see the app container still running. Maybe we can change this issue into: "clean everything up on app removal" or something?

@jvanbaarsen
Copy link
Contributor

👍

@michiels michiels changed the title Remove linked services when app removed? Remove services and running containers when removing an app Jan 25, 2016
jvanbaarsen added a commit to jvanbaarsen/intercity-next that referenced this issue Apr 24, 2016
At the moment we keep the linked service containers running. So if you have a
lot of apps added/removed there are a ton of zombie containers.

By making sure we unlink from the app, and then destroy the service we can free
up the needed resources on the server.

Fixes intercity#80

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
jvanbaarsen added a commit to jvanbaarsen/intercity-next that referenced this issue Apr 25, 2016
At the moment we keep the linked service containers running. So if you have a
lot of apps added/removed there are a ton of zombie containers.

By making sure we unlink from the app, and then destroy the service we can free
up the needed resources on the server.

Fixes intercity#80

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
jvanbaarsen added a commit that referenced this issue Apr 25, 2016
At the moment we keep the linked service containers running. So if you have a
lot of apps added/removed there are a ton of zombie containers.

By making sure we unlink from the app, and then destroy the service we can free
up the needed resources on the server.

Fixes #80

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants