Context restoring #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # scrapypuppeteer/middleware.py
MatthewZMSU
commented
May 29, 2024
Comment on lines
+102
to
+106
| if request_binding: | ||
| # Could not get context, retry | ||
| if request.meta.get("__restore_count", 0) < self.n_retry_restoring: | ||
| request.meta["__restore_count"] += 1 | ||
| return request |
There was a problem hiding this comment.
I'm not sure if this situation even possible.
I could not reproduce it, but I added it here.
What do you think?
|
Service and Recaptcha middlewares were mostly copied from previous middleware.py file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented new downloader middleware for restoring contexts when they are destroyed.
Added example spider.
Added info about the middleware to README.
Restructured the project to have more than 1 middleware. Changed init.py in the corresponding way to provide backward compatibility.
Type of change
How Has This Been Tested?
I tested the middleware with several spuder on my PC.
Checklist: