Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes overload warning when building with ESP IDF #1089

Merged
merged 3 commits into from
May 15, 2024

Conversation

illysky
Copy link
Contributor

@illysky illysky commented May 8, 2024

Similar to previous fixes on overload on getRSSI - a fix was also needed on some of the sleep functions.

Those were added.

@jgromes
Copy link
Owner

jgromes commented May 8, 2024

Thank you for this contribution! Could you also add doxygen comments to the .h files, similar to what was done for getRSSI?

    /*!
      \brief Gets recorded signal strength indicator.
      Overload with packet mode enabled for PhysicalLayer compatibility.
      \returns RSSI value in dBm.
    */
    float getRSSI();

@illysky
Copy link
Contributor Author

illysky commented May 8, 2024 via email

@jgromes jgromes merged commit b336dd5 into jgromes:master May 15, 2024
30 checks passed
@jgromes
Copy link
Owner

jgromes commented May 15, 2024

Since this has been left open for a while, I'm going to merge this as-is and add the doxygen comments afterwards.

Thanks for the contribution!

@illysky
Copy link
Contributor Author

illysky commented May 15, 2024 via email

jgromes added a commit that referenced this pull request May 15, 2024
@jgromes
Copy link
Owner

jgromes commented May 15, 2024

@illysky no worries, just something I wanted to scratch off the TODO list ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants