This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix issue when autoscaling job with mix of groups w/wo policies. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jobs which had 2 groups, one which had a scaling policy and one which did not would panic when running through the autoscaler. This was caused by an unsafe check to see if an allocation was part of a group which had a scaling policy. Closes #70
jrasell
added
kind/bug
|
@numiralofe this should fix the problem you are seeing. I was able to reproduce it locally and therefore test the fix also. Apologies for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs which had 2 groups, one which had a scaling policy and one
which did not would panic when running through the autoscaler.
This was caused by an unsafe check to see if an allocation was
part of a group which had a scaling policy.
Closes #70