feat(launcher): normalize quoted paths

Closes #491
karma-runner · Jul 4, 2013 · f2155e0 · f2155e0
1 parent 42bf787
commit f2155e0
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/launchers/Base.js b/lib/launchers/Base.js
@@ -100,6 +100,12 @@ var BaseBrowser = function(id, emitter, captureTimeout, retryLimit) {
 
 
   this._execCommand = function(cmd, args) {
+    // normalize the cmd, remove quotes (spawn does not like them)
+    if (cmd.charAt(0) === cmd.charAt(cmd.length - 1) && '\'`"'.indexOf(cmd.charAt(0)) !== -1) {
+      cmd = cmd.substring(1, cmd.length - 1);
+      log.warn('The path should not be quoted.\n  Normalized the path to %s', cmd);
+    }
+
     log.debug(cmd + ' ' + args.join(' '));
     self._process = spawn(cmd, args);
 

diff --git a/test/unit/launchers/Base.spec.coffee b/test/unit/launchers/Base.spec.coffee
@@ -99,6 +99,22 @@ describe 'launchers Base', ->
       expect(spawnProcess.kill).to.not.have.been.called
 
 
+    it 'should remove quotes from the cmd', ->
+      browser = new m.BaseBrowser 123
+
+      browser.DEFAULT_CMD = darwin: '"/bin/brow ser"'
+      browser.start '/url'
+      expect(mockSpawn).to.have.been.calledWith '/bin/brow ser', ['/url?id=123']
+
+      browser.DEFAULT_CMD = darwin: '\'bin/brow ser\''
+      browser.start '/url'
+      expect(mockSpawn).to.have.been.calledWith '/bin/brow ser', ['/url?id=123']
+
+      browser.DEFAULT_CMD = darwin: '`bin/brow ser`'
+      browser.start '/url'
+      expect(mockSpawn).to.have.been.calledWith '/bin/brow ser', ['/url?id=123']
+
+
   describe 'kill', ->
     it 'should just fire done if already killed', (done) ->
       browser = new m.BaseBrowser 123, new events.EventEmitter, 0, 1 # disable retry