Feat/add ninja van carrier integration

[codeArtisanry]

Changes

---

Feat:

• Add NinjaVan Integration

[danh91]

The general idea is that while the bootstrap command creates the plugin file structure.

You need to navigate through the files to setup the data and implementation specific to the NinjaVan API operations and logic

[danh91]

The JSON files referenced here need to be from the NinjaVan API.
https://api-docs.ninjavan.co/en

[danh91]

Suggested change

	url=f"{self.settings.server_url}/service",
	url=f"{self.settings.server_url}/1.0/public/price",

This and all the subsequent API requests needs to be based on the corresponding operation from the NinjaVan API.

By example, this one is the Tariff API

[danh91]

Similarly, this one needs to be updated to reflect the Order API

Suggested change

	url=f"{self.settings.server_url}/service",
	url=f"{self.settings.server_url}/4.2/orders",

[danh91]

Same here

[danh91]

And this one for tracking

[danh91]

Suggested change

	gateway = karrio.gateway["ninja_van"].create(
	dict(
	# add required carrier API setting key/value here
	)
	)
	gateway = karrio.gateway["ninja_van"].create(
	dict(
	client_id="client_id",
	client_secret="client_secret",
	)
	)

[danh91]

For the tests, you want to run them and ensure that essentially when a request is created, you get the right output data that needs to be sent to NinjaVan

Sendle is a good example here https://github.com/karrioapi/karrio/blob/main/modules/connectors/sendle/tests/sendle/test_rate.py

[danh91]

Same comment about the tests above

[danh91]

Same here

[danh91]

You need to replace these the the client_id and client_secret that NinjaVan support

[codeArtisanry]

ThankYou so much @danh91 for detailed review and guide
I'll update it and let you know

[codeArtisanry]

Hello @danh91
I'm having trouble in generating migration file can you please help me with that ??

# Generated by Django 4.2.11 on 2024-06-07 11:53

from django.db import migrations, models
import django.db.models.deletion


class Migration(migrations.Migration):

    dependencies = [
        ("providers", "0072_rename_eshippersettings_eshipperxmlsettings_and_more"),
    ]

    operations = [
        migrations.CreateModel(
            name="NinjaVanSettings",
            fields=[
                (
                    "carrier_ptr",
                    models.OneToOneField(
                        auto_created=True,
                        on_delete=django.db.models.deletion.CASCADE,
                        parent_link=True,
                        primary_key=True,
                        serialize=False,
                        to="providers.carrier",
                    ),
                ),
                ("client_id", models.CharField(max_length=255)),
                ("client_secret", models.CharField(max_length=255)),
                (
                    "grant_type",
                    models.CharField(default="client_credentials", max_length=255),
                ),
            ],
            options={
                "verbose_name": "NinjaVan Settings",
                "verbose_name_plural": "NinjaVan Settings",
                "db_table": "ninjavan_settings",
            },
            bases=("providers.carrier",),
        ),
    ]

I wrote mannual migration

[danh91]

Hello @danh91

I'm having trouble in generating migration file can you please help me with that ??

# Generated by Django 4.2.11 on 2024-06-07 11:53



from django.db import migrations, models

import django.db.models.deletion





class Migration(migrations.Migration):



    dependencies = [

        ("providers", "0072_rename_eshippersettings_eshipperxmlsettings_and_more"),

    ]



    operations = [

        migrations.CreateModel(

            name="NinjaVanSettings",

            fields=[

                (

                    "carrier_ptr",

                    models.OneToOneField(

                        auto_created=True,

                        on_delete=django.db.models.deletion.CASCADE,

                        parent_link=True,

                        primary_key=True,

                        serialize=False,

                        to="providers.carrier",

                    ),

                ),

                ("client_id", models.CharField(max_length=255)),

                ("client_secret", models.CharField(max_length=255)),

                (

                    "grant_type",

                    models.CharField(default="client_credentials", max_length=255),

                ),

            ],

            options={

                "verbose_name": "NinjaVan Settings",

                "verbose_name_plural": "NinjaVan Settings",

                "db_table": "ninjavan_settings",

            },

            bases=("providers.carrier",),

        ),

    ]

I wrote mannual migration

Can you share more details?
What command did you run? Did you get any errors?
Is there any error logs you can share?