Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document GatewayAPI example with xkcd application #1040

Merged
merged 2 commits into from
May 27, 2024

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented May 24, 2024

This PR documents additional steps to try http-add-on along with GatewayAPI, similar to how Igress setup is documented.

The selected GatewayAPI implementation Envoy Gateway is stable and well adopted by the community, which should complement the Ingress documentation with nginx-ingress. The HTTPRoute interceptor network path is very similar to the Ingress interceptor path.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Any necessary documentation is added, such as:

see also: #33

@wozniakjan wozniakjan requested a review from a team as a code owner May 24, 2024 14:46
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@JorTurFer
Copy link
Member

Nice improvement!
Does it make sense covering the GatewayAPI integration using an e2e tests? I mean, not for the docs but for the behaviour as a way to don't miss the compatibility (or maybe it's totally an overkill 🤔 )

@wozniakjan
Copy link
Member Author

Does it make sense covering the GatewayAPI integration using an e2e tests?

that is a good point, ok if I tackle that in a standalone PR?

@wozniakjan wozniakjan mentioned this pull request May 27, 2024
1 task
@JorTurFer JorTurFer enabled auto-merge (squash) May 27, 2024 20:55
@JorTurFer JorTurFer merged commit 9f82ff9 into kedacore:main May 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants