Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential typo in Keda documentation #1392

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

hLudde
Copy link
Contributor

@hLudde hLudde commented May 16, 2024

Provide a description of what has been changed

potential typo in Keda documentation and example (I)nitialCooldownPeriod -> (i)nitialCooldownPeriod

Error from terraform when using (I)nitialCooldownPeriod rather than (i)nitialCooldownPeriod:
image

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #
(I)nitialCooldownPeriod -> (i)nitialCooldownPeriod in documentation

potential typo in Keda documentation and example (I)nitialCooldownPeriod -> (i)nitialCooldownPeriod

Signed-off-by: Hans Ludvig Flått-Bjørnstad <hansludvig@hotmail.no>
@hLudde hLudde requested a review from a team as a code owner May 16, 2024 11:56
Copy link

netlify bot commented May 16, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 4ab9064
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6645f7cd43caa500084eb895
😎 Deploy Preview https://deploy-preview-1392--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind updating older versions +2.15 as well please?

Signed-off-by: Hans Ludvig Flått-Bjørnstad <hansludvig@hotmail.no>
@hLudde
Copy link
Contributor Author

hLudde commented May 16, 2024

Hi thanks! yeah did 2.15 now, seems like 2.14 is the version this was introduced :)

@tomkerkhove tomkerkhove merged commit 5056907 into kedacore:main May 17, 2024
8 checks passed
@tomkerkhove
Copy link
Member

Thank you!

rxg8255 pushed a commit to rxg8255/keda-docs that referenced this pull request Jun 27, 2024
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Jun 28, 2024
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants