Prometheus: Mark queryParameters as an optional field instead of an required field #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Hinh <alec4555@gmail.com>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
JorTurFer
reviewed
May 26, 2024
…versions Signed-off-by: Alec Hinh <alec4555@gmail.com>
Thanks for catching that! The other versions should be updated with this change. |
zroubalik
approved these changes
May 29, 2024
rxg8255
pushed a commit
to rxg8255/keda-docs
that referenced
this pull request
Jun 27, 2024
…equired field (kedacore#1395) * Move queryParameters down to the optional field list Signed-off-by: Alec Hinh <alec4555@gmail.com> * Move the query parameters list entries down to optional in the other versions Signed-off-by: Alec Hinh <alec4555@gmail.com> --------- Signed-off-by: Alec Hinh <alec4555@gmail.com> Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
shubhusion
pushed a commit
to shubhusion/keda-docs
that referenced
this pull request
Jun 28, 2024
…equired field (kedacore#1395) * Move queryParameters down to the optional field list Signed-off-by: Alec Hinh <alec4555@gmail.com> * Move the query parameters list entries down to optional in the other versions Signed-off-by: Alec Hinh <alec4555@gmail.com> --------- Signed-off-by: Alec Hinh <alec4555@gmail.com> Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
SpiritZhou
pushed a commit
to SpiritZhou/keda-docs
that referenced
this pull request
Jul 11, 2024
…equired field (kedacore#1395) * Move queryParameters down to the optional field list Signed-off-by: Alec Hinh <alec4555@gmail.com> * Move the query parameters list entries down to optional in the other versions Signed-off-by: Alec Hinh <alec4555@gmail.com> --------- Signed-off-by: Alec Hinh <alec4555@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks the
queryParametersfield as an optional field instead of a required field, as it's actually not mandatory for this field to be configured when deploying new Prometheus triggers.Checklist
Fixes #1394