Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ClusterCloudEventSource #1398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpiritZhou
Copy link
Contributor

Introduce ClusterCloudEventSource

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes # kedacore/keda#5816

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner May 28, 2024 03:03
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented May 28, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit a4f13c0
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/665549876692b0000819a011
😎 Deploy Preview https://deploy-preview-1398--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

@@ -79,6 +79,21 @@ In general, an event emitted by KEDA would fundamentally come down to the follow
}
```

### Scopes: Namespace vs. Cluster

Each `CloudEventSource` is defined in one namespace. For cases where you want to share a single sink among many namespaces, you can instead create a `ClusterCloudEventSource`. As a global object, this can be used from any namespace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each `CloudEventSource` is defined in one namespace. For cases where you want to share a single sink among many namespaces, you can instead create a `ClusterCloudEventSource`. As a global object, this can be used from any namespace.
Each `CloudEventSource` is defined in one namespace and will only subscribe to events inside that namespace. If you want to subscribe to events in all namespaces, you can instead create a `ClusterCloudEventSource` resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants