Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add docs for adding new filter to README #1407

Merged
merged 3 commits into from
Jun 17, 2024
Merged

chore: add docs for adding new filter to README #1407

merged 3 commits into from
Jun 17, 2024

Conversation

thisisobate
Copy link
Contributor

Relates to #412

@thisisobate
chore: add docs for adding new filter to README
b2744e6 
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@thisisobate thisisobate requested a review from a team as a code owner June 14, 2024 18:13
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@thisisobate
Copy link
Contributor Author

@tomkerkhove

@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 77df017
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/666e9e074fc5620008aa748e
😎 Deploy Preview https://deploy-preview-1407--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisisobate
chore: add new step to filter docs
1395c39 
Signed-off-by: thisisobate <obasiuche62@gmail.com>
@thisisobate
chore: nit fix
77df017 
Signed-off-by: thisisobate <obasiuche62@gmail.com>
tomkerkhove
tomkerkhove approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tomkerkhove tomkerkhove merged commit af1e81e into kedacore:main Jun 17, 2024
8 checks passed
rxg8255 pushed a commit to rxg8255/keda-docs that referenced this pull request Jun 27, 2024
@thisisobate
chore: add docs for adding new filter to README (kedacore#1407)
1cc2c73 
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Jun 28, 2024
@thisisobate @shubhusion
chore: add docs for adding new filter to README (kedacore#1407)
4ab758b 
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
SpiritZhou pushed a commit to SpiritZhou/keda-docs that referenced this pull request Jul 11, 2024
@thisisobate @SpiritZhou
chore: add docs for adding new filter to README (kedacore#1407)
58161bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thisisobate @tomkerkhove