feat(metrics): histogram metric for loop latency #5812
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hy3n4 <hy3nk4@gmail.com>
Signed-off-by: Hy3n4 <hy3nk4@gmail.com>
JorTurFer
reviewed
May 27, 2024
Comment on lines
+185
to
+193
| _, err = meter.Float64Histogram( | ||
| "keda.internal.scale.loop.latency.bucket", | ||
| api.WithDescription("Internal latency of ScaledObject/ScaledJob loop execution"), | ||
| api.WithUnit("s"), | ||
| ) | ||
| if err != nil { | ||
| otLog.Error(err, msg) | ||
| } | ||
|
|
There was a problem hiding this comment.
Isn't this the same as the metric just above?
There was a problem hiding this comment.
Well, yes, but unlike the above one, this should be a histogram. But I am not that sure when it comes to otel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to add new histogram type of metric for the internal loop latency. This should be more useful when creating the SLIs.
Checklist