-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor solr scaler config #5818
base: main
Are you sure you want to change the base?
Conversation
/run-e2e |
/run-e2e |
/run-e2e solr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! couple of suggestions for minor improvements below :)
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
/run-e2e solr |
/run-e2e solr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SpiritZhou is this still WIP or can we merge this PR?
we can merge it now. Thanks! |
WIP - Refactor Apache Kafka scaler config using declarative parser from #5676
Checklist
Relates to #5797