Add config as parameter to help validate scaler meta data #5819
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wozniakjan
reviewed
May 23, 2024
| @@ -46,7 +46,7 @@ type activeMQMetadata struct { | |||
| ActivationTargetQueueSize int64 `keda:"name=activationTargetQueueSize, order=triggerMetadata, optional, default=0"` | |||
| } | |||
|
|
|||
| func (a *activeMQMetadata) Validate() error { | |||
| func (a *activeMQMetadata) Validate(_ scalersconfig.ScalerConfig) error { | |||
There was a problem hiding this comment.
given there are currently two configs that implement Validate() and both would ignore this argument, I would like to wait for a little bit before merging the PR.
I understand it will be useful for #5808 but I think it makes sense for now to first see a few more configs refactored and then make a decision. If a good number of configs find it useful, then I'm happy to add it. But if it's just a handful of configs, then perhaps we can consider a different pattern for those that need it without putting restrictions on scaler configs that don't need it, wdyt?
There was a problem hiding this comment.
Sure. Let's wait for other scalers or find another way to do it.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config as parameter in the Validator func so that we can move all validator into this func, such as checking some situation under config.AsMetricSource. #5808 (comment)
Checklist
Relates to # #5037