Update GetAzureQueueLength in azure queue scaler, to support different queue length strategies. #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| }) | ||
|
|
||
| t.Run("Invalid base64 connection string", func(t *testing.T) { | ||
| length, err := GetAzureQueueLength(context.TODO(), kedav1alpha1.AuthPodIdentity{}, "DefaultEndpointsProtocol=https;AccountName=name;AccountKey=key==;EndpointSuffix=core.windows.net", "queueName", "", "", "") |
There was a problem hiding this comment.
| t.Error("Expected error to contain base64 error message, but got", err.Error()) | ||
| } | ||
| t.Run("Empty connection string", func(t *testing.T) { | ||
| length, err := GetAzureQueueLength(context.TODO(), kedav1alpha1.AuthPodIdentity{}, "", "queueName", "", "", "") |
There was a problem hiding this comment.
leodip
force-pushed
the
4478-add-queueLengthStrategy
branch
from
d30026d
to
9b5fa4a
Compare
|
Semgrep found 2 Consider to use well-defined context Ignore this finding from context-todo. |
leodip
force-pushed
the
4478-add-queueLengthStrategy
branch
from
0f64726
to
a95588d
Compare
tomkerkhove
reviewed
Jun 11, 2024
pkg/scalers/azure/azure_queue.go
Outdated
| return int64(props.ApproximateMessagesCount()), nil | ||
| } | ||
|
|
||
| // Default strategy (visible + invisible messages) |
There was a problem hiding this comment.
As per kedacore/keda-docs#1406 (comment) I don't think default is a good name nor do we even use it here?
There was a problem hiding this comment.
Thanks, I have renamed it to 'all'.
JorTurFer
reviewed
Jun 24, 2024
Thanks, hope the new commit makes it better. |
|
@leodip Can you fix merge conflicts please? |
leodip
force-pushed
the
4478-add-queueLengthStrategy
branch
from
bf331d5
to
e2421c0
Compare
…queueLengthStrategy Signed-off-by: Leonardo D'Ippolito <contact@leodip.com>
leodip
force-pushed
the
4478-add-queueLengthStrategy
branch
from
e2421c0
to
6bd92a1
Compare
|
@tomkerkhove I've squashed and rebased - conflicts should be solved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to solve #4478
It adds a new configuration option
queueLengthStrategyto the Azure Storage Queue scaler, where you can set the value ofdefaultorvisibleonly.default: Considers both visible and invisible messages.visibleonly: Uses Peek to count only visible messages. If the count of visible messages is 32 or higher, it falls back to the default strategy, counting both visible and invisible messages.visibleonlywill, in practice, use the previous behaviour, as before #4003 was merged.Docs PR: kedacore/keda-docs#1406.
I've created this change to the best of my ability. However, it hasn't been tested. I would appreciate if someone could help with testing, or giving directions on how to test.
Thanks!