Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Splunk scaler #5905

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Add Splunk scaler #5905

merged 8 commits into from
Jul 1, 2024
+956 −0

Conversation

circa10a
Copy link
Contributor

@circa10a circa10a commented Jun 23, 2024 •
edited by zroubalik
Loading

Support Splunk scaler that utilizes saved searches for scaling.

  1. Issue: Support Splunk scaler #5904
  2. docs PR: feat: splunk scaler docs keda-docs#1413

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
    - [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@circa10a
feat: Splunk scaler
a525a11 
Signed-off-by: circa10a <caleblemoine@gmail.com>
@circa10a circa10a requested a review from a team as a code owner June 23, 2024 16:47
@circa10a circa10a mentioned this pull request Jun 23, 2024
Open
semgrep-app[bot]
semgrep-app bot reviewed Jun 23, 2024
View reviewed changes
pkg/scalers/splunk/splunk.go Outdated Show resolved Hide resolved
semgrep-app[bot]
semgrep-app bot reviewed Jun 23, 2024
View reviewed changes
pkg/scalers/splunk/splunk.go Outdated Show resolved Hide resolved
semgrep-app[bot]
semgrep-app bot reviewed Jun 23, 2024
View reviewed changes
pkg/scalers/splunk/splunk.go Outdated Show resolved Hide resolved
@circa10a circa10a force-pushed the splunk branch 2 times, most recently from c1fab15 to ba069bc Compare June 23, 2024 17:04
@circa10a circa10a mentioned this pull request Jun 23, 2024
Open
1 task
@circa10a
Merge branch 'kedacore:main' into splunk
a4e0506 
Signed-off-by: circa10a <caleblemoine@gmail.com>
zroubalik
zroubalik reviewed Jun 24, 2024
View reviewed changes
pkg/scalers/splunk/splunk.go Outdated Show resolved Hide resolved
pkg/scalers/splunk_scaler.go Outdated Show resolved Hide resolved
@circa10a circa10a force-pushed the splunk branch 3 times, most recently from 6fcf95c to d42a2c9 Compare June 25, 2024 00:26
@circa10a
Merge branch 'kedacore:main' into splunk
8f6a868 
Signed-off-by: circa10a <caleblemoine@gmail.com>
@circa10a
Copy link
Contributor Author

Hmm not sure why the whitesource check is failing. Any ideas?

@zroubalik
Copy link
Member

zroubalik commented Jun 25, 2024 •
edited by github-actions bot
Loading

/run-e2e splunk
Update: You can check the progress here

@zroubalik
Copy link
Member

Hmm not sure why the whitesource check is failing. Any ideas?

Please ingore this, probably a problem on the Whitesource side, I don't see a reason why this should be caused by this PR :)

@circa10a
Merge branch 'main' into splunk
7aaf990 
Signed-off-by: Caleb Lemoine <21261388+circa10a@users.noreply.github.com>
@circa10a
Copy link
Contributor Author

Resolved a conflict with main due to the changelog changes. Will need e2e tests run again

@wozniakjan
Copy link
Member

wozniakjan commented Jun 26, 2024 •
edited by github-actions bot
Loading

/run-e2e splunk
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Jun 27, 2024 •
edited by github-actions bot
Loading

/run-e2e splunk
Update: You can check the progress here

@wozniakjan
Copy link
Member

@zroubalik I think this can be merged, wdyt?

@zroubalik
Copy link
Member

@zroubalik I think this can be merged, wdyt?

there's ongoing discussion in docs PR, let's merge this once we have everything ready.

zroubalik
zroubalik approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@circa10a circa10a force-pushed the splunk branch 2 times, most recently from 2cb30a3 to 8774307 Compare July 1, 2024 15:55
@circa10a
Copy link
Contributor Author

circa10a commented Jul 1, 2024

I updated the PR to source username from auth params based on @tomkerkhove 's feedback in kedacore/keda-docs#1413

@circa10a
move username to auth params
4ec16c8 
Signed-off-by: circa10a <caleblemoine@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Jul 1, 2024 •
edited by github-actions bot
Loading

/run-e2e splunk
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) July 1, 2024 18:27
@zroubalik zroubalik merged commit 9a1d3d2 into kedacore:main Jul 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan left review comments

@semgrep-app semgrep-app[bot] semgrep-app left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@circa10a @zroubalik @wozniakjan