WIP: Proposal for PR changes on ClusterCloudEventSource #5924
+319
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entSource Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
7 tasks
|
I agree with this improvement to reduce code redundancy. Triggerauthentication and clustertriggerauthentication are in the same situation and can be refactored using similar methods. |
SpiritZhou
reviewed
Jul 2, 2024
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(&eventingv1alpha1.ClusterCloudEventSource{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})). |
There was a problem hiding this comment.
Reconciliation cannot accept multiple objects. I think we should still set up multiple controllers and eliminate the duplicates through abstraction.
There was a problem hiding this comment.
ah, you are right, it's been a long time since I used that pattern. Looks like this was supported in controller-runtime older than 0.7.0 but is no longer an option since kubernetes-sigs/controller-runtime#1176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5816 is in the process of introducing cluster scoped version of
CloudEventSource. For simpler PR review, I would like to use this to communicate better some of my ideas for potential improvementsChecklist
Fixes #
Relates to #5816