bump dependencies: kafka and zookeeper #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmr3796
suggested changes
Oct 21, 2022
- 'kafka_2.12', version: '2.4.0' -> 'kafka_2.13', version: '2.8.2' - 'kafka-clients', version: '2.3.1' -> 'kafka-clients', version: '2.8.2' - zookeeper 3.5.6 -> 3.8.0 ## Details new `NetworkClient` arguments: 1. `long connectionSetupTimeoutMs`, 2. `long connectionSetupTimeoutMaxMs` are described in https://issues.apache.org/jira/browse/KAFKA-9893 and corresponding PRs: 1. apache/kafka#8544 2. apache/kafka#8683 ## Testing Done 1. ./gradlew build
gitlw
approved these changes
Oct 21, 2022
lmr3796
approved these changes
Oct 21, 2022
mhratson
added a commit
that referenced
this pull request
Nov 7, 2022
### Problem
- Exception
```
Exception in thread "main" java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.Integer (java.lang.Long and java.lang.Integer are in module java.base of loader 'bootstrap')
at org.apache.kafka.common.config.AbstractConfig.getInt(AbstractConfig.java:173)
at com.linkedin.xinfra.monitor.services.OffsetCommitService.<init>(OffsetCommitService.java:132)
at com.linkedin.xinfra.monitor.services.OffsetCommitServiceFactory.createService(OffsetCommitServiceFactory.java:53)
at com.linkedin.xinfra.monitor.XinfraMonitor.<init>(XinfraMonitor.java:82)
at com.linkedin.xinfra.monitor.XinfraMonitor.main(XinfraMonitor.java:186)
```
- #378 upgade introduced new [arguments for Network client `long connectionSetupTimeoutMs` and `long connectionSetupTimeoutMaxMs`](https://github.com/linkedin/kafka-monitor/pull/378/files#diff-2d490a032d59e6cc9ec2d94cc7fe4311f08a01d1cd67de185dd8e005fa582cd3R131)
- but mistakenly used `getInt` instead of expected `getLong`
## Solition
- use expected `getLong` method
## TODO
- increase test coverage to avoid future regressions
mhratson
added a commit
that referenced
this pull request
Nov 7, 2022
### Problem
- Exception
```
Exception in thread "main" java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.Integer (java.lang.Long and java.lang.Integer are in module java.base of loader 'bootstrap')
at org.apache.kafka.common.config.AbstractConfig.getInt(AbstractConfig.java:173)
at com.linkedin.xinfra.monitor.services.OffsetCommitService.<init>(OffsetCommitService.java:132)
at com.linkedin.xinfra.monitor.services.OffsetCommitServiceFactory.createService(OffsetCommitServiceFactory.java:53)
at com.linkedin.xinfra.monitor.XinfraMonitor.<init>(XinfraMonitor.java:82)
at com.linkedin.xinfra.monitor.XinfraMonitor.main(XinfraMonitor.java:186)
```
- #378 upgade introduced new [arguments for Network client `long connectionSetupTimeoutMs` and `long connectionSetupTimeoutMaxMs`](https://github.com/linkedin/kafka-monitor/pull/378/files#diff-2d490a032d59e6cc9ec2d94cc7fe4311f08a01d1cd67de185dd8e005fa582cd3R131)
- but mistakenly used `getInt` instead of expected `getLong`
## Solition
- use expected `getLong` method
## TODO
- increase test coverage to avoid future regressions
mhratson
added a commit
that referenced
this pull request
Nov 7, 2022
### Problem
- Exception
```
Exception in thread "main" java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.Integer (java.lang.Long and java.lang.Integer are in module java.base of loader 'bootstrap')
at org.apache.kafka.common.config.AbstractConfig.getInt(AbstractConfig.java:173)
at com.linkedin.xinfra.monitor.services.OffsetCommitService.<init>(OffsetCommitService.java:132)
at com.linkedin.xinfra.monitor.services.OffsetCommitServiceFactory.createService(OffsetCommitServiceFactory.java:53)
at com.linkedin.xinfra.monitor.XinfraMonitor.<init>(XinfraMonitor.java:82)
at com.linkedin.xinfra.monitor.XinfraMonitor.main(XinfraMonitor.java:186)
```
- #378 upgade introduced new [arguments for Network client `long connectionSetupTimeoutMs` and `long connectionSetupTimeoutMaxMs`](https://github.com/linkedin/kafka-monitor/pull/378/files#diff-2d490a032d59e6cc9ec2d94cc7fe4311f08a01d1cd67de185dd8e005fa582cd3R131)
- but mistakenly used `getInt` instead of expected `getLong`
## Solition
- use expected `getLong` method
## TODO
- increase test coverage to avoid future regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump dependencies: kafka and zookeeper
Details
new
NetworkClientarguments:long connectionSetupTimeoutMs,long connectionSetupTimeoutMaxMsare described in https://issues.apache.org/jira/browse/KAFKA-9893 and corresponding PRs:
Testing Done