Add support for retries on 429 rate limited requests #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acm19
force-pushed
the
main
branch
3 times, most recently
from
d851c91
to
6396c9d
Compare
nehaev
requested changes
Nov 24, 2023
loki-logback-appender/src/test/java/com/github/loki4j/logback/Loki4jAppenderTest.java
Outdated
Show resolved
Hide resolved
loki-logback-appender/src/test/java/com/github/loki4j/logback/Loki4jAppenderTest.java
Outdated
Show resolved
Hide resolved
|
@nehaev thanks for the review, I've replied to your comments, let me know if you want any other changes. |
nehaev
reviewed
Nov 27, 2023
Adds an option to enable/disable retries on rate limit errors: `dropRateLimitedBatches`. It's enabled by default to keep consistency with Promtail options. Also because Loki scales less aggressively and relies on retries when the load is spiky. Resolves: loki4j#192
nehaev
approved these changes
Nov 28, 2023
|
Great, thanks @nehaev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to enable/disable retries on rate limit errors:
dropRateLimitedBatches. It's enabled by default to keep consistency with Promtail options. Also because Loki scales less aggressively and relies on retries when the load is spiky.Resolves: #192