Fix / Register tracing context manually #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxekman
force-pushed
the
fix-optional-tracing-context
branch
from
ca860a4
to
5bee23c
Compare
maxekman
force-pushed
the
fix-optional-tracing-context
branch
from
5bee23c
to
d19bed9
Compare
maxekman
force-pushed
the
fix-optional-tracing-context
branch
from
d19bed9
to
a7ea4e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should enable Elastic APM to register tracing of events in outbox and event bus handlers.
NOTE: Users of Jaeger will need to call
tracing.RegisterContext()manually.The reason for adding this is described in this issue: elastic/apm#122
Affected Components
Related Issues
Solution and Design
Steps to test and verify