Use Unpack function in archive package #604
Conversation
monstermunchkin
force-pushed
the
misc/unpack
branch
3 times, most recently
from
2967f31
to
988df50
Compare
.github/workflows/test.yml
Outdated
| @@ -27,7 +30,9 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| sudo apt-get -qq update | |||
| sudo apt-get install -y squashfs-tools | |||
| sudo apt-get install -y squashfs-tools libcap-dev libacl1-dev | |||
| sudo add-apt-repository -y ppa:dqlite/dev | |||
There was a problem hiding this comment.
Why does distrobuilder need dqlite or liblxc?
There was a problem hiding this comment.
It's probably importing something from github.com/lxc/lxd which is triggering this, but it'd definitely be preferable to track down what's causing it and split packages differently on the LXD side instead of pulling all of this into distrobuilder.
There was a problem hiding this comment.
Probably the apparmor package, yeah would be good to split.
There was a problem hiding this comment.
The new Unpack() function takes a sys.OS argument. The sys package requires the db package among others. So that's the reason. distrobuilder itself doesn't need either of the mentioned packages.
There was a problem hiding this comment.
Perhaps allowing nil for that specific argument would solve this.
There was a problem hiding this comment.
That explains dqlite, but not liblxc?
Can we decouple sys from db or move sys.OS elsewhere?
There was a problem hiding this comment.
Depends how the liblxc dep is being introduced.
The latest Unpack function from LXD pulls in some unnecessary dependencies. We therefore ship LXD's old Unpack function. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
misc/unpack
branch
from
988df50
to
c6add03
Compare
No description provided.