main: the systemd generator doesn't do anything on VMs #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason why we still include it in VMs is that a VM can be converted to a container with lxd-migrate. The goal actually is to ship the systemd generator in all Ubuntu systems eventually so if they ever get converted to a container, they'll do the right thing. |
|
Alright, let me rework it then. |
simondeziel
force-pushed
the
systemd-generator
branch
2 times, most recently
from
6083372
to
b7bd8a4
Compare
stgraber
reviewed
May 5, 2022
But it is still useful in case the VM is later converted to a container. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
The cloud-init detection is only done when the distro ID matches. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
systemd-generator
branch
from
b7bd8a4
to
9790007
Compare
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
|
@stgraber ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.