Remove a handful of NetworkManager hacks #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
May 6, 2022
monstermunchkin
force-pushed
the
lr/nm-crimes
branch
from
ac42f34
to
c8458a0
Compare
simondeziel
reviewed
May 6, 2022
Let's drop a bunch of arcane hacks that are no longer needed now that
NetworkManager treats the veth eth0 just like an ordinary Ethernet.
Namely:
1.) Don't force eth0 up. NetworkManager will just bring it up itself,
just like a regular Ethernet.
2.) Don't force the device down. NetworkManager doesn't care and it
hasn't cared for many years.
Apart from these things being unnecessary, they make assumtions that are
not correct; such as the connection being called "System eth0". That is
a name generated by the ifcfg compat layer that is going away in next
Fedora release.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
lr/nm-crimes
branch
from
c8458a0
to
03da8f0
Compare
NetworkManager ships with an udev rule that excludes veth devices. The reason is that veths are often used by tooling that would be unhappy if NetworkManager interfered. In containers where /sys is read-only (such as libvirt's LXC backend), systemd-udev is not used and NetworkManager is happy to manage them. With LXD, however, /sys is mounted read-write and systemd-udev runs. While some future version of NetworkManager might solve this somehow, we need this to work with existing versions. Let's just override the rule in question with something that works well with LXD. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
lr/nm-crimes
branch
from
03da8f0
to
4e0ad63
Compare
simondeziel
approved these changes
May 6, 2022
monstermunchkin
added a commit
to monstermunchkin/distrobuilder
that referenced
this pull request
Jun 13, 2022
This reintroduces one of the NetworkManager workarounds which was removed in lxc#633. Without the workaround, some containers only get an IPv4 address after a container reboot. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #602.