-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CentOS mirror updates #645
Conversation
monstermunchkin
commented
Jun 16, 2022
- sources/centos: Disable fastestmirror plugin
- sources/centos: Use baseurl instead of metalink for repos
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
@@ -268,6 +268,11 @@ gpg_keys_official="file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7-aarch64 file:/// | |||
echo gpgcheck=0 >> /etc/yum.repos.d/cdrom.repo | |||
fi | |||
|
|||
# Disable fastestmirror plugin | |||
if [ -f /etc/yum/pluginconf.d/fastestmirror.conf ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does need to be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether fastest mirror overrides the set baseurl. I disabled it to make sure it doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should be encoding arbitrary mirrors in the build code, can we specify these in our own jenkins templates?
Unfortunately not. This is part of the unpack code and it's what's failing on Jenkins. |
Can we add new variable options that can be specified by the jenkins job. Otherwise all users of the image will be pinned to the Canada mirror right? |
Also why different mirrors for different repos BTW? |
What is failing on Jenkins? |
It's different mirrors for different versions. 9-Stream isn't available on https://muug.ca. |
The mirror selection stuff in CentOS/Fedora gives you a very long list of A and AAAA records, so far so good. |
Ah so this is just for the build step. But the dnf config inside the finished image will still use the fastest mirror plugin ? |
That's correct. We could possibly add something like this in the future. For now though, this fix is fine. |
Oh that's ashame. I'll log an issue so we can remember to fix this later. Thanks for explaining. |
For now, yes. I'll be setting a fixed mirror for that as well, because it's probably going to fail, too. |
We probably should revert things just so we don't end up with our users being dependent on our one preferred mirror. |