Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS mirror updates #645

Merged
merged 2 commits into from
Jun 16, 2022
Merged

CentOS mirror updates #645

merged 2 commits into from
Jun 16, 2022

Conversation

monstermunchkin
Copy link
Member

  • sources/centos: Disable fastestmirror plugin
  • sources/centos: Use baseurl instead of metalink for repos

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
@@ -268,6 +268,11 @@ gpg_keys_official="file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7-aarch64 file:///
echo gpgcheck=0 >> /etc/yum.repos.d/cdrom.repo
fi

# Disable fastestmirror plugin
if [ -f /etc/yum/pluginconf.d/fastestmirror.conf ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does need to be disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether fastest mirror overrides the set baseurl. I disabled it to make sure it doesn't.

Copy link
Contributor

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should be encoding arbitrary mirrors in the build code, can we specify these in our own jenkins templates?

@monstermunchkin
Copy link
Member Author

I'm not sure we should be encoding arbitrary mirrors in the build code, can we specify these in our own jenkins templates?

Unfortunately not. This is part of the unpack code and it's what's failing on Jenkins.

@stgraber stgraber merged commit 31d0eed into lxc:master Jun 16, 2022
@tomponline
Copy link
Contributor

Can we add new variable options that can be specified by the jenkins job. Otherwise all users of the image will be pinned to the Canada mirror right?

@tomponline
Copy link
Contributor

Also why different mirrors for different repos BTW?

@tomponline
Copy link
Contributor

What is failing on Jenkins?

@monstermunchkin
Copy link
Member Author

Also why different mirrors for different repos BTW?

It's different mirrors for different versions. 9-Stream isn't available on https://muug.ca.

@stgraber
Copy link
Member

The mirror selection stuff in CentOS/Fedora gives you a very long list of A and AAAA records, so far so good.
Except that a bunch of the AAAA are plain broken, server never answers and things timeout, making the whole image build fail.

@tomponline
Copy link
Contributor

Ah so this is just for the build step. But the dnf config inside the finished image will still use the fastest mirror plugin ?

@monstermunchkin
Copy link
Member Author

Can we add new variable options that can be specified by the jenkins job. Otherwise all users of the image will be pinned to the Canada mirror right?

That's correct. We could possibly add something like this in the future. For now though, this fix is fine.

@tomponline
Copy link
Contributor

Oh that's ashame. I'll log an issue so we can remember to fix this later. Thanks for explaining.

@monstermunchkin
Copy link
Member Author

Ah so this is just for the build step. But the dnf config inside the finished image will still use the fastest mirror plugin ?

For now, yes. I'll be setting a fixed mirror for that as well, because it's probably going to fail, too.

@stgraber
Copy link
Member

For now, yes. I'll be setting a fixed mirror for that as well, because it's probably going to fail, too.

We probably should revert things just so we don't end up with our users being dependent on our one preferred mirror.
Should be pretty easy to save the config and restore it afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants