Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change release style to 22.03-LTS-SPx #678

Merged
merged 1 commit into from
Nov 25, 2022
Merged

change release style to 22.03-LTS-SPx #678

merged 1 commit into from
Nov 25, 2022

Conversation

pkking
Copy link
Contributor

@pkking pkking commented Nov 22, 2022

Change the release style which the openEuler duplicates in both name and release

Signed-off-by: Li Chaoran pkwarcraft@gmail.com

@pkking pkking mentioned this pull request Nov 22, 2022
Merged
@monstermunchkin
Copy link
Member

Dropping the openEuler string is a good start, but not enough. If a user specifies 22.03, we want it to get the latest 22.03 release (currently 22.03-LTS-SP3). But we should also allow specific versions such as 22.03-LTS-SP1. We do something similar for a bunch of our images already.

What we need to do is parse the source of https://repo.openeuler.org/, and do some pattern matching.

@pkking
Copy link
Contributor Author

pkking commented Nov 23, 2022

Dropping the openEuler string is a good start, but not enough. If a user specifies 22.03, we want it to get the latest 22.03 release (currently 22.03-LTS-SP3). But we should also allow specific versions such as 22.03-LTS-SP1. We do something similar for a bunch of our images already.

What we need to do is parse the source of https://repo.openeuler.org/, and do some pattern matching.

inspired by ubuntu-http.go and add some tests :) @monstermunchkin

monstermunchkin
monstermunchkin requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@monstermunchkin monstermunchkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a few small changes, and we're good to go.

sources/openeuler-http.go Show resolved Hide resolved
sources/openeuler-http.go Show resolved Hide resolved
sources/openeuler-http.go Outdated Show resolved Hide resolved
sources/openeuler-http_test.go Outdated Show resolved Hide resolved
@pkking pkking force-pushed the master branch 2 times, most recently from 1400ce4 to afac3c6 Compare November 24, 2022 03:14
monstermunchkin
monstermunchkin requested changes Nov 24, 2022
View reviewed changes
Copy link
Member

@monstermunchkin monstermunchkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done ;)

sources/openeuler-http_test.go Outdated Show resolved Hide resolved
@pkking @monstermunchkin
change release style to 22.03-LTS-SPx and try to select latest version
54d768a 
Signed-off-by: Li Chaoran <pkwarcraft@gmail.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
@monstermunchkin monstermunchkin merged commit 4d4fef8 into lxc:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monstermunchkin monstermunchkin Awaiting requested review from monstermunchkin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkking @monstermunchkin