Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update actions regards to the hook post-files #709

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

silvio
Copy link
Contributor

@silvio silvio commented Mar 23, 2023

In #600 you can read that the post-files-hook is only executed for certain commandos. I think this is worth to be documented.

In lxc#600 you can read that the `post-files`-hook is only executed for certain commandos.
I think this is worth to be documented.
@markkrj
Copy link

markkrj commented Apr 6, 2023

Even better, it would be good if it was actually supported... As I said, build-lxc do create a rootfs tarball, but it also install lxc stuff into it. It would be cool if we could use distrobuilder to build a golden rootfs tarball that could be used for bootstrapping a VM, for example.

@monstermunchkin
Copy link
Member

As I said, build-lxc do create a rootfs tarball, but it also install lxc stuff into it.

@markkrj Right. But you can run distrobuilder build-dir which gives you a rootfs directory. You could then use tar to make a tarball.

@markkrj
Copy link

markkrj commented Apr 6, 2023

But, why is post-files not supported for build-dir?

@monstermunchkin monstermunchkin merged commit d36607c into lxc:master Apr 6, 2023
@monstermunchkin
Copy link
Member

But, why is post-files not supported for build-dir?

The build-dir command is primarily used for preparing a build directory before running pack-lxc or pack-lxd which both support running post-files. However, it would make sense to also support post-files in build-dir. Since I don't want to change the current behaviour, I'm considering adding a new --with-post-files flag to build-dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants