Support trying multiple subnets #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be very appreciated to add! Would love this feature as well! |
|
@hajapy Have you looked into using AWS Fleet API instead of current |
@jpalomaki Interesting, no I hadn't considered that, but it seems like it would be a more elegant solution to this and other issues (also providing options for Spot instances, or mixed spot/on-demand). I don't have capacity to work on this, but it is a nice idea. |
brandboat
added a commit
to Canner/github-runner
that referenced
this pull request
Mar 14, 2022
ported from machulav#85
brandboat
added a commit
to Canner/github-runner
that referenced
this pull request
Mar 14, 2022
ported from machulav#85
brandboat
added a commit
to Canner/github-runner
that referenced
this pull request
Mar 14, 2022
ported from machulav#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AWS is unable to provide an instance in a given availability zone, this action can fail repeatedly (if the condition preventing AWS from having available instances persists). This happens particularly with gpu instance types.
By adding support for multiple subnet ids as input, we can configure the action to try multiple subnets and hence availability zones, giving us a better chance of finding a zone with available instances.