Fix for #5 #8
Merged
Fix for #5 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the build broke, sorry. For some reason the log file is immense, mostly shows pip downloading stuff. |
There is some issues on travis-ci. You may ignore it first |
|
It sounds good. Will accept this merge and updating Word2vecAug and GloVeAug later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix and test for fasttext. This allows to load fasttext models when there are multiple words in a line.
Some models have words like this (Universidade de Sao Paulo's NILC embeddings, for instance) that are correctly loaded by libraries like Spacy.
For instance, a line might have "hello there 0.1 0.2 0.3" etc etc. It's not actually the case for NILC, where the actual bug manifests because of a money expression "R$ 0,00"
I think the same work has to be done for the glove, word2vec, etc but here's how I'm doing in my code.