Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic comments in the generated go files #12

Open
sustrik opened this issue Nov 6, 2020 · 0 comments · May be fixed by #15
Open

Deterministic comments in the generated go files #12

sustrik opened this issue Nov 6, 2020 · 0 comments · May be fixed by #15

Comments

@sustrik
Copy link

sustrik commented Nov 6, 2020 

// Code generated from /home/sustrik/.cache/bazel/_bazel_sustrik/329223ef44c790813be2d08fc6e228b5/sandbox/linux-sandbox/832/execroot/__main__/Foo.g4 by ANTLR 4.7.2. DO NOT EDIT.

Would it be possible to change that to:

// Code generated from Foo.g4 by ANTLR 4.7.2. DO NOT EDIT.

AFAICS this can be achieved by running the generator from the directory in question.
rrbutani added a commit to rrbutani/rules_antlr that referenced this issue May 13, 2021
@rrbutani
Use relative paths for the grammar input files
c766797 
The file paths that are passed to antlr end up in the generated output
so using absolute paths breaks caching.

Fixes marcohu#12.
rrbutani added a commit to rrbutani/rules_antlr that referenced this issue May 14, 2021
@rrbutani
Use relative paths for the grammar input files
b468b28 
The file paths that are passed to antlr end up in the generated output
so using absolute paths breaks caching.

Fixes marcohu#12.
@rrbutani rrbutani linked a pull request May 14, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use relative paths for the grammar input files rrbutani/rules_antlr
1 participant
@sustrik