Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.20... #184

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Use Go 1.20... #184

merged 3 commits into from
Mar 21, 2023

Conversation

slintes
Copy link
Member

@slintes slintes commented Mar 21, 2023

... and prepare to define builder image in this repo instead of Openshift CI's repo for easier updates

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@openshift-ci openshift-ci bot requested review from mshitrit and razo7 March 21, 2023 10:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@slintes
Copy link
Member Author

slintes commented Mar 21, 2023

/retest

@clobrano
Copy link
Contributor

/lgtm

Giving a chance to get more feedbacks, feel free to unhold
/hold

@slintes
Copy link
Member Author

slintes commented Mar 21, 2023

will merge in order to unblock other PRs, this will be tested on their jobs then

/override ci/prow/4.11-openshift-e2e
/override ci/prow/4.12-openshift-e2e
/override ci/prow/4.13-openshift-e2e

/hold cancel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.11-openshift-e2e, ci/prow/4.12-openshift-e2e, ci/prow/4.13-openshift-e2e

In response to this:

will merge in order to unblock other PRs, this will be tested on their jobs then

/override ci/prow/4.11-openshift-e2e
/override ci/prow/4.12-openshift-e2e
/override ci/prow/4.13-openshift-e2e

/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e58c3ab into medik8s:main Mar 21, 2023
@slintes slintes deleted the go_1.20 branch April 25, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants