Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Phony to Makefile #210

Merged
merged 3 commits into from
May 23, 2023
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented May 21, 2023

Follow up to #89 and similar to NMO's PR:

  • Add .PHONY to each target and update it's description (use make help)
  • Add help target and two categories for targets separation

@openshift-ci openshift-ci bot requested review from beekhof and clobrano May 21, 2023 13:47
@razo7 razo7 changed the title Add .Phony to Makefile Add .Phony to Makefile May 22, 2023
Copy link
Member

@slintes slintes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

razo7 added 3 commits May 23, 2023 16:12
To avoid a conflict with a file of the same name, and to improve performance.
Simplify and seperated display of all the targets in the makefile
One less place to modify
@slintes
Copy link
Member

slintes commented May 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1ad2da9 into medik8s:main May 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants