Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (int) in getDefaultParameters() #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rmdhfz
Copy link

@rmdhfz rmdhfz commented Nov 12, 2020

To get the default parameter, int is required. If not :
partner_id and shopid will be strings. That will cause an error

@minchao
Copy link
Owner

minchao commented Nov 12, 2020

Hi @rmdhfz

Thank you for pointing this out.

To avoid property type error. Maybe we should prevent users from setting wrong parameters. When the parameter passed in through the constructor of Client is not a int, throw an exception.

@rmdhfz
Copy link
Author

rmdhfz commented Nov 12, 2020

You are welcome.
Yes, we should prevent users from setting wrong parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants