Remove democracy pallet

[noandrea]

What does it do?

Completely remove the democracy pallet

⚠️ Breaking changes ⚠️

• democracy extrinsics are removed
• the democracy precompile at address 2051 will always revert.

Migrations

• clear democracy storage

What important points reviewers should know?

• the migration will remove all the storage for the democracy pallet, it will not run if there are storage keys left for the Democracy pallet

Is there something left for follow-up PRs?

• cleanup lazy migrations tests introduced for 2800

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions]

Coverage Report

@@                         Coverage Diff                          @@
##           master   noandrea-remove-democracy-pallet      +/-   ##
====================================================================
+ Coverage   80.33%                             80.43%   +0.10%     
- Files         301                                297       -4     
- Lines       93861                              91636    -2225     
====================================================================
- Hits        75395                              73702    -1693     
- Misses      18466                              17934     -532     

Files Changed	Coverage
/node/service/src/chain_spec/moonbase.rs	76.88% (-0.07%)	🔽
/node/service/src/chain_spec/moonbeam.rs	11.74% (+0.03%)	🔼
/node/service/src/chain_spec/moonriver.rs	11.74% (+0.03%)	🔼
/pallets/moonbeam-lazy-migrations/src/lib.rs	89.19% (+18.98%)	🔼
/pallets/moonbeam-lazy-migrations/src/mock.rs	15.71% (+2.26%)	🔼
/precompiles/utils/src/solidity/codec/mod.rs	88.71% (-0.54%)	🔽
/runtime/common/src/migrations.rs	67.96% (+1.78%)	🔼
/runtime/moonbase/src/lib.rs	49.50% (-0.19%)	🔽
/runtime/moonbeam/src/lib.rs	46.05% (-0.15%)	🔽
/runtime/moonriver/src/lib.rs	46.04% (-0.15%)	🔽

Coverage generated Thu Feb 29 20:09:27 UTC 2024

[elfedy]

I am not entirely familiar with the democracy pallet but I wonder why we didn't handle DepositOf storage at all. Don't we need to return funds or something to the folks that deposited to submit a proposal?

[links234]

I am not entirely familiar with the democracy pallet but I wonder why we didn't handle DepositOf storage at all. Don't we need to return funds or something to the folks that deposited to submit a proposal?

DepositOf tracks current proposals. There are no proposals and propose extrinsic is disabled so no need to worry about it.