Set async backing velocity to 1 #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
Agusrodri
approved these changes
Mar 13, 2024
Coverage Report@@ Coverage Diff @@
## master elois-velocity-1 +/- ##
===================================================
Coverage 73.44% 73.44% 0.00%
Files 229 229
Lines 70351 70351
===================================================
Hits 51669 51669
Misses 18682 18682
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Set async backing velocity to 1.
For historical reasons, we had set the velocity to 2 because that's what was recommended by parity at the time we developed async backing, and there was no live network with async backing activated at the time.
Now that several live networks (including Asset Hubs) have async backing activated with a velocity of 1, we know that we can reduce this value to 1.
What's more, velocity 2 poses staking reward distribution problems for collators, as each collator can produce two blocks in a row, preventing the next collator from producing its block.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?
Fair rewards distribution for collators.