Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emergency-para-xcm to Moonbase #2745

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Add emergency-para-xcm to Moonbase #2745

merged 6 commits into from
Apr 10, 2024

Conversation

elfedy
Copy link
Contributor

@elfedy elfedy commented Apr 9, 2024

What does it do?

Adds emergency-para-xcm pallet to Moonbase

Is there something left for follow-up PRs?

This pallet needs to be tested properly with a flow that:

  1. Simulates a parachain "halt" that triggers paused xcm mode.
  2. Verifies we enter the mode and that xcm messages from both hrmp and dmp are enqueued but not processed.
  3. Bring the chain back to "normal" mode and resume operations.

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

Moonsong-Labs/moonkit#34
Moonsong-Labs/moonkit#38

What value does it bring to the blockchain users?

This chains aims to mitigate the risk of a particular xcm halting the chain due to taking a long time to process or generating a big PoV.

@elfedy elfedy added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 9, 2024
@elfedy elfedy added the breaking Needs to be mentioned in breaking changes label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Coverage Report

@@                    Coverage Diff                    @@
##           master   elfedy-auto-pause-xcm      +/-   ##
=========================================================
+ Coverage   72.46%                  72.47%   +0.01%     
  Files         229                     229              
- Lines       70512                   70501      -11     
=========================================================
  Hits        51094                   51094              
- Misses      19418                   19407      -11     
Files Changed Coverage

Coverage generated Wed Apr 10 15:00:17 UTC 2024

@elfedy elfedy added not-breaking Does not need to be mentioned in breaking changes and removed breaking Needs to be mentioned in breaking changes labels Apr 10, 2024
@RomarQ RomarQ merged commit 8865832 into master Apr 10, 2024
33 checks passed
@RomarQ RomarQ deleted the elfedy-auto-pause-xcm branch April 10, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants